Save last ip, user-agent and fingerprint on users #499
+471
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redm4x
force-pushed
the
feat/user-fingerprint
branch
3 times, most recently
from
bf34dbb to
b079f0c
Compare
Redm4x
force-pushed
the
feat/user-fingerprint
branch
from
b079f0c to
8c2268f
Compare
ygrishajev
reviewed
Nov 26, 2024
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE "userSetting" ADD COLUMN "lastIp" varchar(255);--> statement-breakpoint | |||
There was a problem hiding this comment.
Suggested change
| ALTER TABLE "userSetting" ADD COLUMN "lastIp" varchar(255);--> statement-breakpoint | |
| ALTER TABLE "userSetting" ADD COLUMN "last_ip" varchar(255);--> statement-breakpoint |
There was a problem hiding this comment.
cols are named in snake case
There was a problem hiding this comment.
don't you want to implement it this way https://github.com/akash-network/console/blob/main/apps/api/src/core/services/request-context-interceptor/request-context.interceptor.ts ?
| @@ -86,7 +99,10 @@ export async function getSettingsOrInit({ anonymousUserId, userId, wantedUsernam | |||
| email: email, | |||
| emailVerified: emailVerified, | |||
| stripeCustomerId: null, | |||
| subscribedToNewsletter: subscribedToNewsletter | |||
| subscribedToNewsletter: subscribedToNewsletter, | |||
There was a problem hiding this comment.
Suggested change
| subscribedToNewsletter: subscribedToNewsletter, | |
| subscribedToNewsletter, |
| @@ -125,14 +141,26 @@ export async function getSettingsOrInit({ anonymousUserId, userId, wantedUsernam | |||
| email: email, | |||
| emailVerified: emailVerified, | |||
| stripeCustomerId: null, | |||
| subscribedToNewsletter: subscribedToNewsletter | |||
| subscribedToNewsletter: subscribedToNewsletter, | |||
There was a problem hiding this comment.
Suggested change
| subscribedToNewsletter: subscribedToNewsletter, | |
| subscribedToNewsletter, |
| const user = await this.userRepository.create({ | ||
| lastIp: ip, | ||
| lastUserAgent: userAgent, | ||
| lastFingerprint: lastFingerprint |
There was a problem hiding this comment.
Suggested change
| lastFingerprint: lastFingerprint | |
| lastFingerprint |
| @@ -20,8 +20,12 @@ export class UserController { | |||
| private readonly staleAnonymousUsersCleanerService: StaleAnonymousUsersCleanerService | |||
| ) {} | |||
|
|
|||
| async create(): Promise<AnonymousUserResponseOutput> { | |||
| const user = await this.userRepository.create(); | |||
| async create(ip: string | undefined, userAgent: string | undefined, lastFingerprint: string | undefined): Promise<AnonymousUserResponseOutput> { | |||
There was a problem hiding this comment.
let's pass it as an object with params? controller method would generally accept a payload like so
You can access request via execution context here https://github.com/akash-network/console/blob/main/apps/api/src/core/services/request-context-interceptor/request-context.interceptor.ts
baktun14
reviewed
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement basic fingerprinting
clientInfoMiddlewaremiddleware to all routes to add the ip, user-agent and fingerprint to the request context.userSetting).getConnInfofromhono/node-server.predictedBlockDate,predictedDateHeight,providerDeploymentsandtransactionListendpoints were to fix typing issues that surfaced after upgrading.The fingerprinting is done server-side and is inspired by express-fingerprint. It uses information from the following sources to generate a hash: